The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: andrewserong <[email protected]>
Co-authored-by: draganescu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: -25 B (0%)

Total Size: 1.81 MB

_{compressed-size-action}

Thanks for the review!

With this PR applied, though, the preview dropdown is available while editing the template, which feels like an improvement to me. In the main, I think this is good, because it means that while previewing the whole template, users can switch between the different screen sizes:

Thank you, I overlooked this point 😅

One interesting wrinkle in the above case is that while editing the template for a post, the preview link becomes "View site" and will link off to preview the site itself instead of the current post. As the user has switched to template editing, I don't think is a problem as the preview is contextual to what the user is currently doing, but just thought I'd mention it in case it wasn't expected.

I'm struggling with how to address this issue in this PR. I can think of three options:

1. Ship this PR as is. In other words, the "View site" link that appears while editing the template in the post editor is assumed to be intended.

2. Hide the "View site" link while editing a template in the post editor. I can't think of a good way to do this, but for example, we can do it with the following changes:

   Details

   diff --git a/packages/editor/src/components/preview-dropdown/index.js b/packages/editor/src/components/preview- 
   dropdown/index.js
   index e7a19f9254..c0a2222ed0 100644
   --- a/packages/editor/src/components/preview-dropdown/index.js
   +++ b/packages/editor/src/components/preview-dropdown/index.js
   @@ -21,6 +21,7 @@ import { useSelect, useDispatch } from '@wordpress/data';
   import { store as coreStore } from '@wordpress/core-data';
   import { store as preferencesStore } from '@wordpress/preferences';
   import { ActionItem } from '@wordpress/interface';
   +import { getPath } from '@wordpress/url';
   
   /**
    * Internal dependencies
   @@ -58,6 +59,10 @@ export default function PreviewDropdown( { forceIsAutosaveable, disabled } ) {
                  return null;
          }
   
   +       const isSiteEditor = getPath( window.location.href )?.includes(
   +               'site-editor.php'
   +       );
   +
          const popoverProps = {
                  placement: 'bottom-end',
          };
   @@ -124,7 +129,7 @@ export default function PreviewDropdown( { forceIsAutosaveable, disabled } ) {
                                                          onSelect={ handleDevicePreviewChange }
                                                  />
                                          </MenuGroup>
   -                                       { isTemplate && (
   +                                       { isTemplate && isSiteEditor && (
                                                  <MenuGroup>
                                                          <MenuItem
                                                                  href={ homeUrl }

3. While editing a template in the post editor, change the "View site" link to "Preview in new tab." This is probably ideal, but it might require some more complicated changes.

For now, I think option 1 is the best, but what do you think?

@t-hamano I think we should ship this as is. "View site" is technically correct because what happens when you click the button is you go to the homepage. This is consistent with the template editing experience in the site editor.

Arguably, it would be a nicer experience if that button took us to a page using the exact template being edited, but I can see how that might be non-trivial to implement, so for now I think do nothing is our best approach 😄

Thanks for laying out those options @t-hamano!

For now, I think option 1 is the best, but what do you think?

Me too. It took me by a little bit of surprise while editing the template, but not hugely so. And as soon as someone goes back to editing the post itself instead of the template, they get the correct view link.

I'd lean toward landing this as-is, and we can always look into follow-ups if folks wind up finding it confusing.

Thanks for the review! So let's merge this PR and move forward with #66514.